-
Notifications
You must be signed in to change notification settings - Fork 159
Conversation
Fixes #657
Thanks for the work! Here are my observations:
I made some changes and get this. `―― 22:27:19 - Sparkle ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ―― 22:27:42 - Summary ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――― Handbrake was updated after this. |
Here is how I've been doing it successfully on my machine: https://github.com/andreiborisov/sparkle-update/blob/main/functions/sparkle-update.fish tldr:
Better heuristics instead of the step 2 would be nice of course, but not strictly necessary...? Also I've submitted a PR so the CLI would be installable via Homebrew: Homebrew/homebrew-cask#125356, so you probably would want to change the way you call it (it will be available in |
Fixes #657
@andreiborisov I just pushed an update according to your suggestions. |
Fixes #657
Standards checklist:
cargo build
)cargo fmt
)cargo clippy
)cargo test
)If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.