Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands that send messages in DMs crashing the entire bot #248

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

eritbh
Copy link
Member

@eritbh eritbh commented Dec 28, 2023

i hate discord i hate discord i ha

discord no longer sends channel objects for DM channels which means channel objects on messages in DMs are partials which means createMessage doesn't exist on them. this helper calls client.createMessage directly with the channel ID unwrapped from the partial
@eritbh eritbh added the bug Something isn't working label Dec 28, 2023
@eritbh eritbh requested a review from a team as a code owner December 28, 2023 15:11
@eritbh eritbh merged commit ceedc7a into main Dec 28, 2023
2 checks passed
@eritbh eritbh deleted the fix/messages-in-dms branch December 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant