Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): replace toast api #346

Merged
merged 2 commits into from
Jan 27, 2025
Merged

refactor(frontend): replace toast api #346

merged 2 commits into from
Jan 27, 2025

Conversation

zleyyij
Copy link
Contributor

@zleyyij zleyyij commented Jan 26, 2025

This change includes internal ergonomic updates to make usage of the addToast api better

@zleyyij zleyyij requested a review from TheKrol January 26, 2025 02:02
Copy link
Contributor

@TheKrol TheKrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
When switch branches I get this. I also get that image when doing an update pull request, and a regular pull request.

@TheKrol
Copy link
Contributor

TheKrol commented Jan 26, 2025

Other than that everything seems good. Good work sir

@zleyyij zleyyij force-pushed the toast-improvements branch from 9763d5f to f2b1cda Compare January 26, 2025 22:36
@zleyyij zleyyij force-pushed the toast-improvements branch from f2b1cda to 72ceb68 Compare January 26, 2025 22:37
@zleyyij zleyyij requested a review from TheKrol January 26, 2025 22:39
Copy link
Contributor

@TheKrol TheKrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work sir.

@zleyyij zleyyij merged commit 6923b55 into main Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants