Unescape hex/unicode for sample serial data

[akberenz]

For #877

[klabarge]

This arrow function breaks IE11 support

[klabarge]

Can this be rewritten like so?

        serialData.data = serialData.data.replace(/\\n/g, "\n").replace(/\\r/g, "\r").replace(/\\t/g, "\t")
            .replace(/\\[xu]([\dA-Fa-f]+)/g, (m, s1).then(function() {
                String.fromCharCode(parseInt(s1, 16))
            })
        );

[akberenz]

yes, but i found a case in retesting where the \x codes can try to collect too many values to convert because of the \u regex combo, so I pushed up a change where the function is a variable to be used for both now split

[klabarge]

What data should I be testing?

I'm kind of arbitrarily sending stuff so not sure if it's valid.

Test 1

send: hi, serial port\n
logs:"data":"hi, serial port\n"

Test 2

send: hi, serial port\u
logs:"data":"hi, serial port\\u"
error: java.lang.IllegalArgumentException: Less than 4 hex digits in unicode value: '\u' due to end of CharSequence

[tresf]

What data should I be testing?

I'm kind of arbitrarily sending stuff so not sure if it's valid.

Test 1

send: hi, serial port\n logs:"data":"hi, serial port\n"

Test 2

send: hi, serial port\u logs:"data":"hi, serial port\\u" error: java.lang.IllegalArgumentException: Less than 4 hex digits in unicode value: '\u' due to end of CharSequence

Those are pretty good tests. Some known hex would be nice (newline, tab, a-z stuff, but in hex format).

[klabarge]

I sent hex with new lines and tabs and it seems ok.

68 69 0A 09 73 65 72 69 61 6C 0A 70 6F 72 74

[tresf]

thanks
	kyle
merging