-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow spool limits for pdf prints #728
Conversation
@bberenz I believe we need to add some form of backwards compatibility routine or else QZ Tray 2.1.3+ will take the old
Edit: No, I think that logic is flawed. Hmm... Ideas welcome. Maybe we need to start sending the |
Should we just put the pixel option under a different property? |
I quite prefer keeping raw and pixel using similar APIs. I was trying to find an API indicator suggesting that My proposal to yours is similar but uses an object. I'm not sure if this is overkill, but would make home to more spool control parameters in the future. For example, if we find a way to control winspool's behavior such as "keep spooled documents", or "send directly to the printer", etc although these may be better suited in a non- |
That'd probably be the way to go besides just blanket ignoring a value of 1 for pixel spools then. |
Implemented object notation via 4f1b58b (untested). Feedback welcome. |
✅ PASS: QZ Tray |
Documentation updated: https://qz.io/wiki/2.1-Pixel-Printing#advanced-print-spooling. Raw documentation still uses the old syntax for now, but I've added a note about the new syntax. https://github.com/qzind/tray/wiki/2.1-Raw-Printing#advanced-print-spooling |
Reference
qz.configs.create('Zebra',
{ perSpool: 10 }
qz.configs.create('Zebra',
{ spool: { size: 10 } } )
Raw only
qz.configs.create('Zebra',
{ endOfDoc: '^XZ' }
qz.configs.create('Zebra',
{ spool: { end: '^XZ' } } )
Compatibility:
perSpool option added for pdf pixel prints, closes #727