-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify runtests and CI settings for JET
#63
Conversation
I understand your idea. We can try to do the following if you agree:
In this way, the What do you think? |
test/code-quality/Project.toml
Outdated
@@ -1,3 +1,4 @@ | |||
[deps] | |||
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" | |||
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b" | |||
QuantumToolbox = "6c2fb7c5-b903-41d2-bc5e-5a7c320b9fab" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, having QuantumToolbox in the Project.toml (without the Manifest file) would install the latest stable version of the package, and not the local dev package. That's why I installed the local package directly from the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right !
test/runtests.jl
Outdated
|
||
if (GROUP == "All") || (GROUP == "Code-Quality") | ||
Pkg.activate("code-quality") | ||
Pkg.develop(PackageSpec(path = dirname(@__DIR__))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this, since we are already using the local del version of QuantumToolbox.
This PR merges two CI config file into a single one
Runtests.yml
.Also, merge the
test/code-quality/runtest.jl
into the standardtest/runtest.jl
file but keep the environment separate forJET
. This allows the developers to run both test groups (Core
andCode-Quality
) in local with one single command:(QuantumToolbox) pkg> test
but also run separately in GitHub CI pipeline.
Summary of this PR:
CI-Core.yml
andCI-Code-Quality.yml
intoRuntests.yml
code-quality/runtests.jl
into standardruntests.jl
file