Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify runtests and CI settings for JET #63

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Apr 8, 2024

This PR merges two CI config file into a single one Runtests.yml.

Also, merge the test/code-quality/runtest.jl into the standard test/runtest.jl file but keep the environment separate for JET. This allows the developers to run both test groups (Core and Code-Quality) in local with one single command:

(QuantumToolbox) pkg> test

but also run separately in GitHub CI pipeline.

Summary of this PR:

  • merge CI-Core.yml and CI-Code-Quality.yml into Runtests.yml
  • merge code-quality/runtests.jl into standard runtests.jl file

@ytdHuang ytdHuang requested a review from albertomercurio April 8, 2024 13:07
@albertomercurio
Copy link
Member

I understand your idea. We can try to do the following if you agree:

  • We remove the code-quality environment
  • In the runtests.jl file we add the Aqua.jl and JET.jl packages through the Pkg.jl package.
  • We include the code quality test files
  • We use the CI file you propose here

In this way, the Aqua.jl and JET.jl packages are not present in the Project.toml file, but they are installed only in the case of the Code Quality test.

What do you think?

@@ -1,3 +1,4 @@
[deps]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
QuantumToolbox = "6c2fb7c5-b903-41d2-bc5e-5a7c320b9fab"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, having QuantumToolbox in the Project.toml (without the Manifest file) would install the latest stable version of the package, and not the local dev package. That's why I installed the local package directly from the CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right !

test/runtests.jl Outdated

if (GROUP == "All") || (GROUP == "Code-Quality")
Pkg.activate("code-quality")
Pkg.develop(PackageSpec(path = dirname(@__DIR__)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this, since we are already using the local del version of QuantumToolbox.

@albertomercurio albertomercurio merged commit af9b237 into albertomercurio/JET Apr 8, 2024
@ytdHuang ytdHuang deleted the fix/JET branch April 8, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants