Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make steadystate function almost compatible with GPU arrays #119

Merged
merged 2 commits into from
May 22, 2024

Conversation

albertomercurio
Copy link
Member

@albertomercurio albertomercurio commented May 22, 2024

I make the steadystate function GPU-compatible.

I now create the matrix and the vector for the linear system, depending on the type of the input liouvillian.

Currently, the only feature not yet supported by GPUs is A \ b, but it might be implemented in the future.

This could be solved using iterative algorithms of LinearSolve.jl, which will be implemented in the next PRs related to #81.

To make this, I needed to import the ArrayInterface.jl package, in order to use the allowed_setindex! function. This function allows to perform scalar indexing in a controlled way, that is exactly needed in this case.

@albertomercurio albertomercurio requested a review from ytdHuang May 22, 2024 12:17
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.04%. Comparing base (f0a6e1c) to head (9757448).

Files Patch % Lines
src/general_functions.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   91.04%   91.04%   -0.01%     
==========================================
  Files          21       21              
  Lines        1754     1765      +11     
==========================================
+ Hits         1597     1607      +10     
- Misses        157      158       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit e73ee0a into main May 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants