Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underdamped terminator #131

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

cerisola
Copy link
Contributor

The current PR is a follow up of #124 which adds the terminator for underdamped spectral densities.

I have not been able to find analytical expressions for the terminator in the literature (or other packages, QuTiP lacks it as well), so I derived it myself. I attach here the calculation for reference / cross-checking:

derivation

I have tested the implemented terminator for a couple of different Hamiltonians (2, 3, and 4 level systems) and a few different parameter sets and they seem to work correctly.

Here I attach an example for the case of a spin-boson model:

underdamped_terminator_comparison

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (a62be5c) to head (b5d847c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   91.68%   91.69%           
=======================================
  Files          24       24           
  Lines        1480     1481    +1     
=======================================
+ Hits         1357     1358    +1     
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang ytdHuang merged commit 985b48a into qutip:main Dec 19, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants