Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo rename of values-in as values-id #3035

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Undo rename of values-in as values-id #3035

merged 1 commit into from
Dec 26, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 26, 2024

This reverts 4846493, which breaks
Indonesian on devices pre-Android 35. The documentation suggests this
type of change is only for the Locale api, and not for the resources
themselves.

This reverts 4846493, which breaks
Indonesian on devices pre-Android 35. The documentation suggests this
type of change is only for the Locale api, and not for the resources
themselves.
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  24.1 MiB │  24.1 MiB │      0 B │  74.8 MiB │  74.8 MiB │      0 B 
     arsc │   2.7 MiB │   2.7 MiB │ -3.6 KiB │   2.7 MiB │   2.7 MiB │ -3.6 KiB 
 manifest │   5.8 KiB │   5.8 KiB │      0 B │    28 KiB │    28 KiB │      0 B 
      res │   1.7 MiB │   1.7 MiB │      0 B │     2 MiB │     2 MiB │      0 B 
   native │  18.8 KiB │  18.8 KiB │      0 B │  36.5 KiB │  36.5 KiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 218.4 KiB │ 218.4 KiB │     +6 B │ 464.6 KiB │ 464.6 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  29.2 MiB │  29.2 MiB │ -3.6 KiB │  80.6 MiB │  80.6 MiB │ -3.6 KiB 

@ahmedre ahmedre added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit adb6e2c Dec 26, 2024
2 checks passed
@ahmedre ahmedre deleted the reset_indonesian branch December 26, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant