Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dark mode as the default #3020

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Use dark mode as the default #3020

merged 1 commit into from
Dec 15, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 15, 2024

For now, set the default mode to be dark mode. In the future, in sha'
Allah, there will be a setting for either day, night, or follow system.
For people who have the app installed, it will default to dark. For new
installations, it'll follow system by default. This will be in the
future though, in sha' Allah.

For now, set the default mode to be dark mode. In the future, in sha'
Allah, there will be a setting for either day, night, or follow system.
For people who have the app installed, it will default to dark. For new
installations, it'll follow system by default. This will be in the
future though, in sha' Allah.
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │  24.1 MiB │  24.1 MiB │ +19 B │  74.7 MiB │  74.7 MiB │ +100 B 
     arsc │   2.7 MiB │   2.7 MiB │   0 B │   2.7 MiB │   2.7 MiB │    0 B 
 manifest │   5.8 KiB │   5.8 KiB │   0 B │    28 KiB │    28 KiB │    0 B 
      res │   1.7 MiB │   1.7 MiB │  +2 B │     2 MiB │     2 MiB │    0 B 
   native │  18.8 KiB │  18.8 KiB │   0 B │  36.5 KiB │  36.5 KiB │    0 B 
    asset │ 404.2 KiB │ 404.2 KiB │   0 B │ 678.6 KiB │ 678.6 KiB │    0 B 
    other │ 218.3 KiB │ 218.3 KiB │ +10 B │ 464.6 KiB │ 464.6 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │  29.2 MiB │  29.2 MiB │ +31 B │  80.6 MiB │  80.6 MiB │ +100 B 

@ahmedre ahmedre added this pull request to the merge queue Dec 15, 2024
Merged via the queue into main with commit 3d8e2de Dec 15, 2024
2 checks passed
@ahmedre ahmedre deleted the dark_mode_by_default branch December 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant