Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the position of the page number for line pages #3019

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 14, 2024

This patch fixes a bug that caused the page number to be on the wrong
side while in Arabic. This is likely due to removing the hack that had
the parent layout for the entire page as an LTR layout. Consequently,
when this flag was removed, the actual page numbers were sometimes
rendered the opposite direction due to smart row components flipping the
direction of the children for RTL.

This patch fixes a bug that caused the page number to be on the wrong
side while in Arabic. This is likely due to removing the hack that had
the parent layout for the entire page as an LTR layout. Consequently,
when this flag was removed, the actual page numbers were sometimes
rendered the opposite direction due to smart row components flipping the
direction of the children for RTL.
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │  24.1 MiB │  24.1 MiB │  0 B │  74.7 MiB │  74.7 MiB │  0 B 
     arsc │   2.7 MiB │   2.7 MiB │  0 B │   2.7 MiB │   2.7 MiB │  0 B 
 manifest │   5.8 KiB │   5.8 KiB │  0 B │    28 KiB │    28 KiB │  0 B 
      res │   1.7 MiB │   1.7 MiB │  0 B │     2 MiB │     2 MiB │  0 B 
   native │  18.8 KiB │  18.8 KiB │  0 B │  36.5 KiB │  36.5 KiB │  0 B 
    asset │ 404.2 KiB │ 404.2 KiB │  0 B │ 678.6 KiB │ 678.6 KiB │  0 B 
    other │ 218.3 KiB │ 218.3 KiB │ -4 B │ 464.6 KiB │ 464.6 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  29.2 MiB │  29.2 MiB │ -4 B │  80.6 MiB │  80.6 MiB │  0 B 

@ahmedre ahmedre added this pull request to the merge queue Dec 14, 2024
Merged via the queue into main with commit 854c2f2 Dec 14, 2024
2 checks passed
@ahmedre ahmedre deleted the fix_page_number branch December 14, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant