Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bookmarks widget not updating #2999

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix bookmarks widget not updating #2999

merged 1 commit into from
Dec 5, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 5, 2024

This patch fixes a bug where the bookmarks widgets were no longer being
updated due to the recent refactor of bookmarks. Since the deprecated
BookmarkModel was being watched for changes, and since most new code
updates BookmarksDao instead, the widget never got the changes. This
patch fixes it so that the widgets update whenever either get updates.

@ahmedre ahmedre enabled auto-merge December 5, 2024 22:11
This patch fixes a bug where the bookmarks widgets were no longer being
updated due to the recent refactor of bookmarks. Since the deprecated
BookmarkModel was being watched for changes, and since most new code
updates BookmarksDao instead, the widget never got the changes. This
patch fixes it so that the widgets update whenever either get updates.
@ahmedre ahmedre force-pushed the fix_widget_updates branch from 71ee882 to ad07fc0 Compare December 5, 2024 22:19
@ahmedre ahmedre added this pull request to the merge queue Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  24.1 MiB │  24.1 MiB │ +1.6 KiB │  74.7 MiB │  74.7 MiB │ +3.6 KiB 
     arsc │   2.7 MiB │   2.7 MiB │      0 B │   2.7 MiB │   2.7 MiB │      0 B 
 manifest │   5.8 KiB │   5.8 KiB │      0 B │    28 KiB │    28 KiB │      0 B 
      res │   1.7 MiB │   1.7 MiB │      0 B │     2 MiB │     2 MiB │      0 B 
   native │  18.8 KiB │  18.8 KiB │      0 B │  36.5 KiB │  36.5 KiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 218.4 KiB │ 218.4 KiB │     +8 B │ 464.6 KiB │ 464.6 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  29.2 MiB │  29.2 MiB │ +1.6 KiB │  80.6 MiB │  80.6 MiB │ +3.6 KiB 

Merged via the queue into main with commit d8b3feb Dec 5, 2024
2 checks passed
@ahmedre ahmedre deleted the fix_widget_updates branch December 5, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant