Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ayah and translation font sizes to be independently changed #2644

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

jayfan0
Copy link

@jayfan0 jayfan0 commented Mar 26, 2024

This PR addresses #2042 by allowing the arabic ayahs and translation font sizes to be independently changed

Jzk for all your your efforts

Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  20.3 MiB │  20.3 MiB │   +358 B │  65.5 MiB │  65.5 MiB │   +1 KiB 
     arsc │   2.2 MiB │   2.2 MiB │   +860 B │   2.2 MiB │   2.2 MiB │   +860 B 
 manifest │   5.6 KiB │   5.6 KiB │      0 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │    +38 B │   1.8 MiB │   1.8 MiB │   +248 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │ 188.6 KiB │ 188.6 KiB │    -35 B │ 385.6 KiB │ 385.6 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  24.7 MiB │  24.7 MiB │ +1.2 KiB │  70.6 MiB │  70.6 MiB │ +2.1 KiB 


Copy link
Contributor

@ahmedre ahmedre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jazakumAllah khairan, this looks good!

@ahmedre ahmedre merged commit 2e4996e into quran:main Mar 30, 2024
4 checks passed
ahmedre added a commit that referenced this pull request Mar 30, 2024
This will allow a one time upgrade to copy the translation text size
into the ayah text size after splitting them in #2644.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants