Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column name issue with translation database #2538

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Jan 12, 2024

Older versions of the translation database (versions 2 and 3) added and
had a translator_foreign field. In version 4, this was renamed to
translatorForeign. The code assumed it was always named as
translatorForeign, which is incorrect, thus crashing for people
upgrading from older versions.

Older versions of the translation database (versions 2 and 3) added and
had a translator_foreign field. In version 4, this was renamed to
translatorForeign. The code assumed it was always named as
translatorForeign, which is incorrect, thus crashing for people
upgrading from older versions.
@ahmedre ahmedre force-pushed the fix_bad_translation_upgrade branch from 5fda765 to 203ca22 Compare January 12, 2024 20:08
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │  12.6 MiB │  12.6 MiB │ +18 B │    32 MiB │    32 MiB │ +4 B 
     arsc │   2.2 MiB │   2.2 MiB │   0 B │   2.2 MiB │   2.2 MiB │  0 B 
 manifest │   5.6 KiB │   5.6 KiB │   0 B │  27.1 KiB │  27.1 KiB │  0 B 
      res │   1.6 MiB │   1.6 MiB │   0 B │   1.8 MiB │   1.8 MiB │  0 B 
    asset │ 404.2 KiB │ 404.2 KiB │   0 B │ 678.6 KiB │ 678.6 KiB │  0 B 
    other │ 189.2 KiB │ 189.2 KiB │ -14 B │ 387.5 KiB │ 387.5 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │    17 MiB │    17 MiB │  +4 B │  37.1 MiB │  37.1 MiB │ +4 B 


@ahmedre ahmedre merged commit d067daa into master Jan 12, 2024
4 checks passed
@ahmedre ahmedre deleted the fix_bad_translation_upgrade branch January 12, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant