Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sqldelight for translations #2485

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Use Sqldelight for translations #2485

merged 1 commit into from
Dec 9, 2023

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Dec 9, 2023

No description provided.

Copy link

github-actions bot commented Dec 9, 2023

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed             │           uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
      dex │  12.6 MiB │  12.6 MiB │ +19.3 KiB │  31.9 MiB │    32 MiB │ +58.8 KiB 
     arsc │   2.2 MiB │   2.2 MiB │       0 B │   2.2 MiB │   2.2 MiB │       0 B 
 manifest │   5.6 KiB │   5.6 KiB │       0 B │  27.1 KiB │  27.1 KiB │       0 B 
      res │   1.6 MiB │   1.6 MiB │       0 B │   1.8 MiB │   1.8 MiB │       0 B 
    asset │ 404.2 KiB │ 404.2 KiB │       0 B │ 678.6 KiB │ 678.6 KiB │       0 B 
    other │ 188.2 KiB │ 188.2 KiB │     -14 B │ 384.8 KiB │ 384.8 KiB │       0 B 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
    total │  16.9 MiB │    17 MiB │ +19.3 KiB │    37 MiB │    37 MiB │ +58.8 KiB 


Copy link

github-actions bot commented Dec 9, 2023

New Dependencies
project :common:translation

@ahmedre ahmedre force-pushed the translations_cleanup branch 3 times, most recently from 73253a2 to 65cf102 Compare December 9, 2023 21:29
@ahmedre ahmedre force-pushed the translations_cleanup branch from 65cf102 to 294af52 Compare December 9, 2023 21:33
Copy link

github-actions bot commented Dec 9, 2023

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed             │           uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff      
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
      dex │  12.6 MiB │  12.6 MiB │ +19.5 KiB │  31.9 MiB │    32 MiB │ +59.1 KiB 
     arsc │   2.2 MiB │   2.2 MiB │       0 B │   2.2 MiB │   2.2 MiB │       0 B 
 manifest │   5.6 KiB │   5.6 KiB │       0 B │  27.1 KiB │  27.1 KiB │       0 B 
      res │   1.6 MiB │   1.6 MiB │       0 B │   1.8 MiB │   1.8 MiB │       0 B 
    asset │ 404.2 KiB │ 404.2 KiB │       0 B │ 678.6 KiB │ 678.6 KiB │       0 B 
    other │ 188.2 KiB │ 188.2 KiB │     -22 B │ 384.8 KiB │ 384.8 KiB │       0 B 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼───────────
    total │  16.9 MiB │    17 MiB │ +19.5 KiB │    37 MiB │    37 MiB │ +59.1 KiB 


Copy link

github-actions bot commented Dec 9, 2023

New Dependencies
project :common:translation

@ahmedre ahmedre merged commit a593617 into master Dec 9, 2023
4 checks passed
@ahmedre ahmedre deleted the translations_cleanup branch December 9, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant