Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sheikh Muhammad Rashad Shereef #1920

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Mar 22, 2022

No description provided.

@ahmedre
Copy link
Contributor Author

ahmedre commented Mar 22, 2022

jazakumAllah khairan @naushervan for contributing this recitation.

@ahmedre ahmedre merged commit 42b838c into master Mar 22, 2022
@ahmedre ahmedre deleted the add_muhammad_rashad_shereef branch March 22, 2022 00:29
@naushervan
Copy link

JazākAllāhu khairā brother!

Perhaps it's going to take some time for the update to reach our phones as it's not available yet. I'll check it again tomorrow, in-shāʾAllāh.

I also wanted to bring to your notice that the reciter's list is not fully alphabetically sorted. Most of the names are sorted, but a couple are not. Dr. Ayman Suwaid and Minshawy Mujawwad are mistakenly at the very end of the list.

@ahmedre
Copy link
Contributor Author

ahmedre commented Mar 22, 2022

waiyyakum - update hasn't been posted yet akhi, but in sha' Allah hoping to get one out before Ramadan.

re: sorting - it's because non-gapless recitations are left to the bottom of the list to discourage people from using them. we hope to eventually move away from gapped recitations.

@naushervan
Copy link

JazākAllāhu khairā for informing me about the state of the app, as I was assuming that the app may have been updated already.

It will be most kind of you if you can inform me after the update has been posted so that I can message the brother that his request has been fulfilled. We also need to close the following issue after the app is updated:
quran/quran.com-api#331

JazākAllāhu khairā!

@ahmedre
Copy link
Contributor Author

ahmedre commented Mar 23, 2022

waiyyakum, will try to remember to post here, but if I forget, it'll be in the releases tab in sha' Allah.

regarding the linked quran.com-api issue, that's separate because that work is still needed to expose it on the website to people not using the mobile apps (people using quran.com directly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants