Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection across multiple pages #1852

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Jan 22, 2022

When selecting ayahs over multiple pages, the menu did not move to the
new page. This patch fixes it so now ayat can be selected on multiple
pages as was the case before. Note that there is a limit of 2 pages
worth of ayat (well, 4 if in tablet mode or side by side view, which
probably should be reduced in the future).

When selecting ayahs over multiple pages, the menu did not move to the
new page. This patch fixes it so now ayat can be selected on multiple
pages as was the case before. Note that there is a limit of 2 pages
worth of ayat (well, 4 if in tablet mode or side by side view, which
probably should be reduced in the future).
@ahmedre ahmedre merged commit 9809995 into master Jan 22, 2022
@ahmedre ahmedre deleted the fix_selection_across_pages branch January 22, 2022 19:04
@nacer80
Copy link

nacer80 commented Mar 24, 2022

السلام عليكم ورحمة الله وبركاته
Still, this issue is not fixed when we choose large screens pages(madinah 1439).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants