Add scrollbar to QuranActivity #1549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah sadly it's minSdk 21 and we're not yet - though hoping to soon in sha' Allah |
|
jazakumAllah khiaran - merged but switched to using the in built RecyclerView functionality since we're not showing a thumb overlay for now |
|
see adfe6ad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1370.
Originally, I put effort into adding a popup that appears when you scroll. But choosing the text to display in the popup wasn't 100% straightforward (but that was doable). But then the different heights of views in the recycler view and the heights of at least one view type depending on the contents meant I got rid of the popup.
Note that this PR adds a third-party dependency, but hopefully this is ok. Debug build is ~0.6MB larger on my phone, I haven't checked the release build.