feat: add speedup & down to sound player UI

[MahmoudMabrok]

implement the feature at #1529

[princeparacha58]

Assalam mu alikum brother, i need speed up and speed down in quran andriod audio player please add in your software jazakallah

[MahmoudMabrok]

@princeparacha58 I think now we have hadr recitation, so if still need this feature, we can have a build from this PR, but I think it will not have all data sources in current app version.

closed as hadr recitation added.

[ahmedre]

let's keep it open, thinking to merge it but with guidelines on what max speed to set depending on the Qari's rate of recitation, since this remains the top requested feature.

[MahmoudMabrok]

if will be merged @ahmedre I would spend today and rest of week on working on it.

I really want to contribute and help Quran users.

[ahmedre]

planning to merge it in sha' Allah - جزاكم الله خيراً for building it and really sorry for being quiet about it all this time (as you know, I was against this idea from earlier on, but after discussions and brother @mohamede1945's idea to keep things beneficial, and it being the top feature request), planning on seeing this through in sha' Allah.

[MahmoudMabrok]

No problem my brother, so I think we can make make 1.5(as max to all recitation) until we get a comprehensive solution to be related to Quran recitation type, do you agree @ahmedre ?

I follow rule said write, revisit, refactor, enhance

[ahmedre]

Sure, that sounds reasonable. Cc @mohamede1945 fyi

[MahmoudMabrok]

@ahmedre I have pushed the changes. please check

[ahmedre]

overall looks good, جزاكم الله خيراً

a few minor things:

1. we probably should have some pre-sets instead (ex 0.5x, 0.75x, 1x, 1.25x, 1.5x) instead of a dynamic increase/decrease.
2. if this only works on M+, let's not show the ui components for versions less than M

[MahmoudMabrok]

@ahmedre these pre sets will be in code only or will reflect in UI.

[ahmedre]

we'd need to reflect in the UI also. for the audio bar, we can do the same as repeat (if you tap the repeat icon, the number cycles there between the valid repeat amounts). then, we can also expose a similar layout to repeat in the settings bottom sheet.

[github-actions]

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  12.6 MiB │  12.6 MiB │   +592 B │    32 MiB │    32 MiB │ +1.7 KiB 
     arsc │   2.2 MiB │   2.2 MiB │   +292 B │   2.2 MiB │   2.2 MiB │   +292 B 
 manifest │   5.6 KiB │   5.6 KiB │     -1 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │ +1,002 B │   1.8 MiB │   1.8 MiB │ +1.3 KiB 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │   189 KiB │ 189.2 KiB │   +176 B │ 387.1 KiB │ 387.5 KiB │   +402 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │    17 MiB │    17 MiB │   +2 KiB │  37.1 MiB │  37.1 MiB │ +3.6 KiB 

[mohamede1945]

Sure, that sounds reasonable. Cc @mohamede1945 fyi

Sounds great. Jazak Allah Khyran. And thanks brother @MahmoudMabrok for implementing it.

BTW, Here is the list that the quran.com website shows. I think this PR will be just for [0.5, 0.75, 1, 1.25, 1.5], right?

[MahmoudMabrok]

@ahmedre
@mohamede1945

as agreed I added them as pre-sets.
I had to move text above icon into left as space was small [check final screenshot]

[github-actions]

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  12.6 MiB │  12.6 MiB │ +1.1 KiB │    32 MiB │    32 MiB │ +2.3 KiB 
     arsc │   2.2 MiB │   2.2 MiB │   +140 B │   2.2 MiB │   2.2 MiB │   +140 B 
 manifest │   5.6 KiB │   5.6 KiB │     -1 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │   +507 B │   1.8 MiB │   1.8 MiB │   +704 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │   189 KiB │ 189.1 KiB │   +133 B │ 387.1 KiB │ 387.3 KiB │   +194 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │    17 MiB │    17 MiB │ +1.8 KiB │  37.1 MiB │  37.1 MiB │ +3.3 KiB 

[ahmedre]

جزاكم الله خيراً
Did some minor clean up - it's still not ready yet, need to figure out a fix for sura transitions where the speed delta gets lost when one sura ends and another starts to play. Likely need to put the speed inside the AudioRequest itself. Will look over the weekend or next week in sha' Allah.

[github-actions]

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff   
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼────────
      dex │  12.6 MiB │  12.6 MiB │   +900 B │    32 MiB │    32 MiB │ +2 KiB 
     arsc │   2.2 MiB │   2.2 MiB │   +140 B │   2.2 MiB │   2.2 MiB │ +140 B 
 manifest │   5.6 KiB │   5.6 KiB │     -1 B │  27.1 KiB │  27.1 KiB │    0 B 
      res │   1.6 MiB │   1.6 MiB │   +508 B │   1.8 MiB │   1.8 MiB │ +704 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │    0 B 
    other │   189 KiB │ 189.1 KiB │   +125 B │ 387.1 KiB │ 387.3 KiB │ +194 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼────────
    total │    17 MiB │    17 MiB │ +1.6 KiB │  37.1 MiB │  37.1 MiB │ +3 KiB 

[MahmoudMabrok]

I tried to add to AudioRequest but faced a lot of issues.
I will check ISA.

[ahmedre]

@MahmoudMabrok I've fixed some issues (including when we transition suras, the playback speed is now properly maintained). I still see two things before we can merge this:

1. the bigger problem - repeat seek timings are off when repeating at a higher play rate - ex play and press the button to repeat the ayah (and make speed 1.5x) - you'll notice that it reads the ayah and some of the next before going back (at 1x it's fine). note that "seek" itself is fine - i.e. going to the next or previous ayah goes to the correct time stamp.
2. nice to have - expose this in the audio panel settings - I've added the wiring, just needs the ui piece.

I think the first is caused by our audio check being at 1x - we need to run this more (or less) frequently to fix. the second one just needs to be done. just updating you so you know.

[github-actions]

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  12.6 MiB │  12.6 MiB │ +1.3 KiB │    32 MiB │    32 MiB │ +2.9 KiB 
     arsc │   2.2 MiB │   2.2 MiB │   +140 B │   2.2 MiB │   2.2 MiB │   +140 B 
 manifest │   5.6 KiB │   5.6 KiB │     -1 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │   +508 B │   1.8 MiB │   1.8 MiB │   +704 B 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │   189 KiB │ 189.1 KiB │   +121 B │ 387.1 KiB │ 387.3 KiB │   +194 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │    17 MiB │    17 MiB │ +2.1 KiB │  37.1 MiB │  37.1 MiB │ +3.9 KiB 

[github-actions]

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  12.6 MiB │  12.6 MiB │ +2.5 KiB │    32 MiB │    32 MiB │ +5.3 KiB 
     arsc │   2.2 MiB │   2.2 MiB │   +712 B │   2.2 MiB │   2.2 MiB │   +708 B 
 manifest │   5.6 KiB │   5.6 KiB │     -1 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │ +1.3 KiB │   1.8 MiB │   1.8 MiB │ +2.5 KiB 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │   189 KiB │ 189.2 KiB │   +190 B │ 387.1 KiB │ 387.5 KiB │   +396 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │    17 MiB │    17 MiB │ +4.7 KiB │  37.1 MiB │  37.1 MiB │ +8.9 KiB 

[github-actions]

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │            compressed            │           uncompressed            
          ├───────────┬───────────┬──────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff      
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
      dex │  12.6 MiB │  12.6 MiB │ +2.5 KiB │    32 MiB │    32 MiB │  +5.3 KiB 
     arsc │   2.2 MiB │   2.2 MiB │   +2 KiB │   2.2 MiB │   2.2 MiB │    +2 KiB 
 manifest │   5.6 KiB │   5.6 KiB │     -1 B │  27.1 KiB │  27.1 KiB │       0 B 
      res │   1.6 MiB │   1.6 MiB │ +1.3 KiB │   1.8 MiB │   1.8 MiB │  +2.5 KiB 
    asset │ 404.2 KiB │ 404.2 KiB │      0 B │ 678.6 KiB │ 678.6 KiB │       0 B 
    other │   189 KiB │ 189.2 KiB │   +178 B │ 387.1 KiB │ 387.5 KiB │    +396 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
    total │    17 MiB │    17 MiB │   +6 KiB │  37.1 MiB │  37.1 MiB │ +10.2 KiB 

[ahmedre]

aforementioned changes made al7amdulillah.
جزاكم الله خيراً @MahmoudMabrok

[MahmoudMabrok]

Thanks so much for your efforts and merge.