Text size and brightness preferences to show a preview under seek bar #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amynbe
commented
Jan 2, 2021
| @@ -432,7 +432,7 @@ internal class TranslationAdapter(private val context: Context, | |||
|
|
|||
| companion object { | |||
| private val USE_UTHMANI_SPAN = Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP | |||
| private const val ARABIC_MULTIPLIER = 1.4f | |||
There was a problem hiding this comment.
making this public so SeekBarTextSizePreference can show an accurate preview of arabic text size
| @@ -51,6 +51,28 @@ | |||
| /> | |||
| </LinearLayout> | |||
|
|
|||
There was a problem hiding this comment.
Adding these 2 text views under the seekbar, one for arabic and one for the translated language.
They are hidden by default in SeekBarPreference.java and the overriding classes opt in to show them and do something with them (i.e apply text size or brightness on them).
ahmedre
approved these changes
Jan 30, 2021
| android:id="@+id/arabic_preview" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:text="معاينة" |
There was a problem hiding this comment.
should be @string/prefs_preview and we should add to values-ar/strings.xml
There was a problem hiding this comment.
oh - i see why now - will just show one depending on the language
| android:id="@+id/arabic_preview" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:text="معاينة" |
|
jazakumAllah khairan - merged here - 25a8d74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#708
pref_preview.mp4