Improve highlighting behavior in translation view #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch: - treats audio highlights differently than selection highlights (though both aren't enabled at the same time yet). This allows audio highlighting to not show a menu, and clicking an ayah to not highlight that ayah unless we're already in selection mode. - clear selection mode when audio highlight overwrites selection highlight, and when long pressing an already selected ayah.
ahmedre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
both aren't enabled at the same time yet). This allows audio
highlighting to not show a menu, and clicking an ayah to not highlight
that ayah unless we're already in selection mode.
highlight, and when long pressing an already selected ayah.