Improvements to scoped storage #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedre
force-pushed
the
scoped_storage
branch
from
49dc608 to
b9e9512
Compare
ahmedre
commented
Nov 6, 2020
Comment on lines
348
to
349
| <string name="scoped_storage_message"> | ||
| بسبب تغييرات في الاندرويد، إستخدام مكان غير مكان التطبيق قد يسبب في عدم تمكن التطبيق من الوصول للملفات في الاصدارات المستقبلية لاندرويد. هل ترغب في تكملة نقل البيانات ؟ |
There was a problem hiding this comment.
@benomaire does this sound ok or can you suggest something better?
There was a problem hiding this comment.
Another variation:
بسبب القيود الجديدة في أندرويد 11، تخزين بيانات التطبيق في مكان غير مجلد التطبيق الافتراضي قد يؤدي إلى عدم تمكن التطبيق من الوصول لملفاته في إصدارات أندرويد القادمة، هل ترغب في نقل البيانات على أية حال؟
ahmedre
force-pushed
the
scoped_storage
branch
from
b9e9512 to
046412b
Compare
benomaire
reviewed
Nov 6, 2020
| @@ -343,7 +343,10 @@ | |||
| <string name="import_data_error">ملف النسخة الاحتياطية تالف (أو فشلت قراءة النسخة الاحتياطية)</string> | |||
| <string name="import_data_permissions_error">فشلت قراءة ملف النسخة الاحتياطية بسبب فقدان الإذن</string> | |||
| <string name="please_grant_permissions">رجاء امنح الإذن في الإعدادات</string> | |||
| <string name="about_noorhidayat" translatable="false">نور وهداية (Noorhidayat)</string> | |||
| <string name="about_noorhidayat" translatable="false">نور هداية (Noorhidayat)</string> | |||
There was a problem hiding this comment.
I guessed from the url and the logo that 'e' stands for 'و' in urdu. I am not sure though!
There was a problem hiding this comment.
ok i'll leave it like it was
This patch updates scoped storage, making the following changes: 1. only force copying on Android 11 (sdk 30) and above. Before, this was also enabled for Android 10 (sdk 29). 2. disable the advanced settings move option to copy to /sdcard on Android 30 and above (since it doesn't make sense anymore). 3. warn people on Android 29 when they try to explicitly use /sdcard that data might not remain accessible on future Android versions. 4. show warning before asking for external sdcard permissions if required. Fixes #1478.
ahmedre
force-pushed
the
scoped_storage
branch
from
046412b to
43f1b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates scoped storage, making the following changes:
also enabled for Android 10 (sdk 29).
Android 30 and above (since it doesn't make sense anymore).
that data might not remain accessible on future Android versions.
required.
Fixes #1478.