Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI Strings #1487

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Update UI Strings #1487

merged 3 commits into from
Nov 6, 2020

Conversation

benomaire
Copy link
Contributor

Mainly adding missing Arabic strings.

@ahmedre
Copy link
Contributor

ahmedre commented Nov 6, 2020

جزاكم الله خيراً
let me know when this is ready can merge, barak Allah feekum

@benomaire
Copy link
Contributor Author

Please comment on adding (الوضع العربي) in English. If you don't like it, I will revert it. Otherwise, I think it should be added to other languages.

@ahmedre
Copy link
Contributor

ahmedre commented Nov 6, 2020

sure, in the Arabic one, can we add the English in it as well (get a few people often asking "how do I get out of Arabic mode?" so that would help them also)

@benomaire
Copy link
Contributor Author

But I think that way is not unique! Should we just have English?

@ahmedre
Copy link
Contributor

ahmedre commented Nov 6, 2020

yeah it's not ideal i guess - because depending on the language people have set, the string would be wrong. maybe we leave them as they are for now.

@benomaire benomaire marked this pull request as ready for review November 6, 2020 18:22
@benomaire benomaire marked this pull request as draft November 6, 2020 18:24
@benomaire
Copy link
Contributor Author

For Arabic,
How about using
إلغاء هذا الوضع يؤدي إلى استعمال لغة الجهاز الافتراضية
instead of
سيتم تحويل التطبيق إلى اللغة العربية
?

@ahmedre
Copy link
Contributor

ahmedre commented Nov 6, 2020

I like
سيتم تحويل التطبيق إلى اللغة العربية
more since it's clearer - that selecting this option will cause the app to be in Arabic.

@benomaire benomaire marked this pull request as ready for review November 6, 2020 18:32
@benomaire
Copy link
Contributor Author

If no other comments, feel free to merge.

Copy link
Contributor

@ahmedre ahmedre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

جزاكم الله خيراً

@ahmedre ahmedre merged commit 7740503 into quran:master Nov 6, 2020
@benomaire benomaire deleted the UpdateUIStrings branch November 6, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants