Fix bugs with the partial page checker and tablet #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al7amdulillah, got really lucky here! The parital page checker had a number of bugs - namely it used the width where it should have used the tablet width. Consequently, it marks a massive number of pages as "to be deleted." Due to another bug though (looping over only the pages to delete instead of all pages to delete), al7amdulillah the pages didn't actually get deleted in this case. This fixes these bugs.
|
السلام عليكم ورحمة الله وبركاته ملف اضافة الشيخ أحمد بن علي العجمي تجدونه في الرسائل المرفقة، علما ان الملف مجرب ويشتغل في التطبيق بصفة جيدة جدا. نرجوا منكم اضافة الشيخ الى قائمة القراء. بارك الله فيكم وجزاكم الله خيرا |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Al7amdulillah, got really lucky here! The parital page checker had a
number of bugs - namely it used the width where it should have used the
tablet width. Consequently, it marks a massive number of pages as "to be
deleted." Due to another bug though (looping over only the pages to
delete instead of all pages to delete), al7amdulillah the pages didn't
actually get deleted in this case. This fixes these bugs.