Don't start audio service in foreground #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the audio service is always started when the app is in the foreground, and since there are still many ANRs due to not calling startForeground quickly enough (though it's the earliest thing that happens in the service), there is likely a race condition in which at certain points of time, audio playback is stopped and removes the notification and stops the service before startForeground is called. As a workaround, just start the service in the background. This is possible since the app is in the foreground at this point in time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the audio service is always started when the app is in the
foreground, and since there are still many ANRs due to not calling
startForeground quickly enough (though it's the earliest thing that
happens in the service), there is likely a race condition in which at
certain points of time, audio playback is stopped and removes the
notification and stops the service before startForeground is called. As
a workaround, just start the service in the background. This is possible
since the app is in the foreground at this point in time.