Start services as foreground sooner #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a service is started as foreground, make the startForeground call (along with showing the notification) one of the first things that the service does.
ahmedre
commented
Mar 15, 2019
| @@ -357,6 +357,12 @@ public int onStartCommand(Intent intent, int flags, int startId) { | |||
| } | |||
|
|
|||
| final String action = intent.getAction(); | |||
| if (ACTION_PLAYBACK.equals(action)) { | |||
There was a problem hiding this comment.
just moving it up sooner - and start foreground even if we're already foreground (multiple calls are fine, but missing a call is asking for a crash).
| @@ -233,6 +231,12 @@ private void sendNoOpMessage(int id) { | |||
|
|
|||
| @Override | |||
| public int onStartCommand(Intent intent, int flags, int startId) { | |||
| // if it's a download, it wants to be a foreground service. | |||
| // quickly start as foreground before actually enqueueing the request. | |||
| if (ACTION_DOWNLOAD_URL.equals(intent.getAction())) { | |||
There was a problem hiding this comment.
this is actually a lot sooner than where it was happening before - before, handleOnStartCommand would process the message and then give it to the handler, which would eventually start foreground and show the notification. on some devices, this could take so long, so make it the first thing we do.
|
|
||
| lastMaximum = -1; | ||
| lastProgress = -1; | ||
| showNotification(title, appContext.getString(R.string.downloading_message), |
There was a problem hiding this comment.
most important here is the flag for foreground being explicitly set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a service is started as foreground, make the startForeground
call (along with showing the notification) one of the first things that
the service does.