Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reordering of translations #1179

Closed
ahmedre opened this issue May 6, 2019 · 3 comments
Closed

support reordering of translations #1179

ahmedre opened this issue May 6, 2019 · 3 comments

Comments

@ahmedre
Copy link
Contributor

ahmedre commented May 6, 2019

say you have 3 translations - what if you want a particular one first and then another and then a third? we should allow re-ordering of translations.

@papasmile
Copy link
Contributor

Assalaam alaykum, @ahmedre . Similarly, what about a simple 'favorite translation' option, then have a small divider between favorites and others?

Relating to your suggestion, where would newly added translations get put in that list? At the bottom, perhaps? Any ideas on where to do re-ordering? Perhaps a 'settings' header menu with a 'reorder translations' options that puts that screen into a reorder mode (with a 'done' button)?

@ahmedre
Copy link
Contributor Author

ahmedre commented Apr 16, 2020

not sure how we are ordering these right now - but let's say this is low priority for now. i think if we want to do it we can just enable that ordering from the translation manager screen itself.

@papasmile
Copy link
Contributor

salam, @ahmedre It looks like we initially display in order of database IDs:

Also, display order changes whenever a translation is checked/selected:

Anyway, If I'm understanding you right your idea is to have some kind of ordering interface in settings then honor setting in ayah display (and action bar).

Also, you're saying 'low priority'... is there another mainly-code task that would be better to pick up?

papasmile added a commit to papasmile/quran_android that referenced this issue Jul 7, 2020
papasmile added a commit to papasmile/quran_android that referenced this issue Jul 7, 2020
ahmedre added a commit that referenced this issue Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants