-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support reordering of translations #1179
Comments
Assalaam alaykum, @ahmedre . Similarly, what about a simple 'favorite translation' option, then have a small divider between favorites and others? Relating to your suggestion, where would newly added translations get put in that list? At the bottom, perhaps? Any ideas on where to do re-ordering? Perhaps a 'settings' header menu with a 'reorder translations' options that puts that screen into a reorder mode (with a 'done' button)? |
not sure how we are ordering these right now - but let's say this is low priority for now. i think if we want to do it we can just enable that ordering from the translation manager screen itself. |
salam, @ahmedre It looks like we initially display in order of database IDs: quran_android/app/src/main/java/com/quran/labs/androidquran/database/TranslationsDBAdapter.java Line 73 in 15c9221
quran_android/app/src/main/java/com/quran/labs/androidquran/ui/PagerActivity.java Line 1348 in 654b336
Also, display order changes whenever a translation is checked/selected: quran_android/app/src/main/java/com/quran/labs/androidquran/ui/util/TranslationsSpinnerAdapter.java Line 65 in 18bd051
Anyway, If I'm understanding you right your idea is to have some kind of ordering interface in settings then honor setting in ayah display (and action bar). Also, you're saying 'low priority'... is there another mainly-code task that would be better to pick up? |
say you have 3 translations - what if you want a particular one first and then another and then a third? we should allow re-ordering of translations.
The text was updated successfully, but these errors were encountered: