Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basmallah should have a shadda in 95 and 97 #30

Closed
ahmedre opened this issue Mar 19, 2019 · 1 comment
Closed

basmallah should have a shadda in 95 and 97 #30

ahmedre opened this issue Mar 19, 2019 · 1 comment

Comments

@ahmedre
Copy link
Contributor

ahmedre commented Mar 19, 2019 •
edited
Loading

i think the script uses the exact same QCF_BSML font to draw all bismillah on every page. there are 2 exceptions that should have been made, one for sura 95 and one for sura 97. both should have a shadda on the b.

WhatsApp Image 2019-03-19 at 3 43 34 PM

WhatsApp Image 2019-03-19 at 3 44 04 PM
@ahmedre ahmedre mentioned this issue Mar 19, 2019
Closed
@ahmedre
Copy link
Contributor Author

ahmedre commented Mar 19, 2019

to fix this, in the database, we should change the glyph 64337 to 64340 for:

  • 87950 (page 597, sura teen)
  • 88094 (page 598, sura qadr)

@ahmedre ahmedre changed the title basmallah should have a shadda in 96 and 97 basmallah should have a shadda in 95 and 97 Mar 19, 2019
ahmedre added a commit that referenced this issue Mar 19, 2019
@ahmedre
Basmallah should have a shaddah in 95 and 97
009adbf 
This patch replaces the basmallah glyph with the one that has a shaddah
for suras Tin and Qadr (pages 597 and 598). Fixes #30.
@ahmedre ahmedre mentioned this issue Mar 19, 2019
Merged
@ahmedre ahmedre mentioned this issue Apr 7, 2019
Merged
ahmedre added a commit to quran/quran_android that referenced this issue Apr 7, 2019
@ahmedre
Update legacy madani pages to v6 (#1133)
2103097 
The basmallah on pages 597 and 598 should have a shaddah. This patch
pulls in quran/quran.com-images#30 and thereby fixes #640.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahmedre