This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Implement stop button in audio player #850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:32922 |
azeezolaniran2016
force-pushed
the
feature/add-audio-player-stop-button
branch
from
7c63fc0 to
0a1790a
Compare
|
@naveed-ahmad let's pause on this until RR4 is out please? |
|
Deployed to: http://staging.quran.com:32924 |
|
Player doesn't look good, we've space lets use it :)
|
|
@mmahalwy Okay with the pause😄. Please, can you help me look at the staging app, I can't seem to figure out why there's a bit of a replay between the end of a surah and the beginning of another. I could not reproduce this bug locally. |
|
Deployed to: http://staging.quran.com:32943 |
|
@azeezolaniran2016 can i close this? |
|
@mmahalwy Thanks for reaching out. I will close this right away, as I haven't had the bandwidth to continue working on it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
#673: Stop button in audio player
Description:
Add stop button and implement stop feature in audio player.