This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Sort language in dropdown alphabetically #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:32820 |
|
Just realized that the |
|
Deployed to: http://staging.quran.com:32821 |
| @@ -4,6 +4,22 @@ import MenuItem from 'react-bootstrap/lib/MenuItem'; | |||
|
|
|||
| const style = require('./style.scss'); | |||
|
|
|||
| const compareAlphabetically = property => | |||
| (a, b) => { | |||
There was a problem hiding this comment.
perhaps make it more specific, as in (previous, next) ?
|
@haritsE that would be awesome! |
|
Deployed to: http://staging.quran.com:32822 |
|
@haritsE let me know when this is ready :) |
|
@mmahalwy done 👍 |
|
Thank you! |
thabti
pushed a commit
to thabti/quran.com-frontend
that referenced
this pull request
Aug 27, 2016
* sort language alphabetically * use compareAlphabetically on the slugs declaration * rename sort function params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sort languages in the dropdown alphabetically.
Issue: #57