Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check end instead of relying on room creation event as the room timeline start #508

Closed
KitsuneRal opened this issue Sep 20, 2021 · 0 comments · Fixed by #593
Closed

Check end instead of relying on room creation event as the room timeline start #508

KitsuneRal opened this issue Sep 20, 2021 · 0 comments · Fixed by #593
Assignees
@KitsuneRal
Labels
enhancement A feature or change request for the library

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Sep 20, 2021 •
edited
Loading

According to the discussion in matrix-org/matrix-spec-proposals#2251, it is the most appropriate way to find out whether all history is loaded.
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Sep 20, 2021
@KitsuneRal KitsuneRal self-assigned this Nov 20, 2022
@KitsuneRal KitsuneRal changed the title getPreviousContent should treat start == end as the end of the timeline Check end instead of relying on room creation event as the room timeline start Nov 20, 2022
KitsuneRal added a commit that referenced this issue Nov 21, 2022
@KitsuneRal
Use Room::P::prevBatch to track if all history is loaded
07caf3f 
...instead of a presence of RoomCreateEvent in the timeline.

Closes #508.
KitsuneRal added a commit that referenced this issue Nov 21, 2022
@KitsuneRal
Use Room::P::prevBatch to track if all history is loaded
e04e6da 
...instead of a presence of RoomCreateEvent in the timeline.

Closes #508.
KitsuneRal added a commit that referenced this issue Nov 21, 2022
@KitsuneRal
Use Room::P::prevBatch to track if all history is loaded
2fff7a8 
...instead of a presence of RoomCreateEvent in the timeline.

Closes #508.
@KitsuneRal KitsuneRal mentioned this issue Nov 21, 2022
Merged
@KitsuneRal KitsuneRal moved this to Version 0.7 - Done in libQuotient 1 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: Version 0.7 - Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Room::P::prevBatch to track if all history is loaded quotient-im/libQuotient
1 participant
@KitsuneRal