Profile dialog #677
Merged
Profile dialog #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitsuneRal
requested changes
Jul 22, 2020
client/mainwindow.cpp
Outdated
Comment on lines
800
to
803
| this, [=] | ||
| { | ||
| auto* dlg = new ProfileDialog(c->user(), this); | ||
| dlg->setModal(false); | ||
| dlg->setAttribute(Qt::WA_DeleteOnClose); | ||
| dlg->reactivate(); | ||
| }); |
There was a problem hiding this comment.
You might have seen summon() used in other places to achieve the same effect and also provide lazy initialisation:
Suggested change
| this, [=] | |
| { | |
| auto* dlg = new ProfileDialog(c->user(), this); | |
| dlg->setModal(false); | |
| dlg->setAttribute(Qt::WA_DeleteOnClose); | |
| dlg->reactivate(); | |
| }); | |
| this, [this,c,dlg=QPointer<ProfileDialog>{}]() mutable | |
| { | |
| summon(dlg, c->user(), this); | |
| }); |
Being pre-C++17, other places use static declaration instead of an initialisation in the capture block and making the lambda mutable - the C++17 way is slightly cleaner because it destructs the dialog when the lambda is destructed (in this case - when the connection is logged out). Ideally it should destruct the dialog with deleteLater() but I'm yet to commit the facility class to do that.
client/profiledialog.cpp
Outdated
Comment on lines
49
to
51
| //auto mainLayout = new QFormLayout; | ||
| //profileWidget->setLayout(mainLayout); | ||
|
|
There was a problem hiding this comment.
Suggested change
| //auto mainLayout = new QFormLayout; | |
| //profileWidget->setLayout(mainLayout); |
client/profiledialog.cpp
Outdated
| topLayout->addLayout(essentialsLayout); | ||
| } | ||
|
|
||
| //mainLayout->addRow(topLayout); |
There was a problem hiding this comment.
Suggested change
| //mainLayout->addRow(topLayout); |
client/profiledialog.cpp
Outdated
| connect(devicesJob, &BaseJob::success, this, [=] { | ||
| m_deviceTable->setRowCount(devicesJob->devices().size()); | ||
|
|
||
| for (int i = 0; i < devicesJob->devices().size(); i++) { |
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < devicesJob->devices().size(); i++) { | |
| for (int i = 0; i < devicesJob->devices().size(); ++i) { |
client/profiledialog.cpp
Outdated
| if (!m_avatarUrl.isEmpty()) | ||
| m_user->setAvatar(m_avatarUrl); | ||
|
|
||
| for (auto d: m_devices) { |
There was a problem hiding this comment.
Suggested change
| for (auto d: m_devices) { | |
| for (const auto& deviceIt = m_devices.begin(); it != m_devices.end(); ++it) { |
client/profiledialog.cpp
Outdated
| m_user->setAvatar(m_avatarUrl); | ||
|
|
||
| for (auto d: m_devices) { | ||
| auto list = m_deviceTable->findItems(m_devices.key(d), Qt::MatchExactly); |
There was a problem hiding this comment.
Suggested change
| auto list = m_deviceTable->findItems(m_devices.key(d), Qt::MatchExactly); | |
| auto list = m_deviceTable->findItems(deviceIt.key(), Qt::MatchExactly); |
client/profiledialog.cpp
Outdated
Comment on lines
161
to
162
| if (!list.isEmpty() && newName != d) | ||
| m_user->connection()->callApi<Quotient::UpdateDeviceJob>(m_devices.key(d), newName); |
There was a problem hiding this comment.
Suggested change
| if (!list.isEmpty() && newName != d) | |
| m_user->connection()->callApi<Quotient::UpdateDeviceJob>(m_devices.key(d), newName); | |
| if (!list.isEmpty() && newName != deviceIt.value()) | |
| m_user->connection()->callApi<Quotient::UpdateDeviceJob>(deviceIt.key(), newName); |
Changing display name and avatar is now possible.
...and take Quotient::User* instead of Quotient::Connection* as the first argument.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added uploading user avatar, changing display name, and viewing and renaming devices.
Closes #28
Contributes to #268 – I have no idea how to reveal an access token here.