New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some optimizations for union formation #521

Merged

JelleZijlstra merged 1 commit into master from optimize

Apr 13, 2022

Contributor

JelleZijlstra commented Apr 13, 2022

No description provided.


          Some optimizations for union formation

487a3fe

JelleZijlstra commented

View reviewed changes

pyanalyze/value.py

                           try:
                               # Don't readd it to preserve original ordering.
                               if subval not in hashable_vals:
                                   hashable_vals[subval] = None
                           except Exception:
                               unhashable_vals.append(subval)
                   existing = list(hashable_vals) + unhashable_vals
-                  num = len(existing)
+                  reachabilities = [_is_unreachable(val) for val in existing]

Contributor Author

JelleZijlstra Apr 13, 2022

This defers the _is_unreachable call until after we have deduplicated the values, so we don't call it repeatedly if we have lots of duplicates.

JelleZijlstra merged commit 0f995f4 into master

JelleZijlstra deleted the optimize branch

April 13, 2022 18:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet