-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle destructor #927
Merged
Merged
Particle destructor #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…-astro/quokka into chong/particle/destructor
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
BenWibking
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall design looks good to me.
|
BenWibking
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support particle destruction.
Changes:
ParticleDestructionTraits
. The user define their own particle destructor by specializing theParticleChecker
method inParticleDestructionTraits
, which return true or false to mark a particle for destruction. As a placeholder,particles.param3
is used in particle destructor.ParticleDestructionImpl
, which loops over all particles at a level and mark particles for destruction.getNumParticles
function toPhysicsParticleDescriptor
to get the total number of valid particles of that type.particles.verbose
to turn on printing particle logistics at each time step. Currently, it prints the number of particles of each type.The new particle destructor feature is tested in gravity_3d.cpp.
Next, I'll add a
particleDestruction
method inParticleDestructionTraits
, which modifies the hydro state while removing a particle.Related issues
None.
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
x
inside the square brackets[ ]
in the Markdown source below:/azp run
.