Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: local native logger and better OOBE #761

Merged
merged 13 commits into from
Dec 31, 2024
Merged

feat: local native logger and better OOBE #761

merged 13 commits into from
Dec 31, 2024

Conversation

ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Dec 28, 2024 •
edited
Loading

  • New local logger helps users debug and obtain logs more easily

    • It currently only covers the Native App and Extension native parts

    • That means only covering the Swift part and not the JS part

    • There is no built-in upload feature, users always need to share logs manually (e.g. attached to an issue)

  • Mac App no ​​longer uses storyboard, but shares webview with iOS version

    • Newly designed logger caveats and interactive interface

    • App webview adds custom I18n implementation and L10n

    • More friendly OOBE and usage guide for first-time users

  • Other miscellaneous updates and refactorings

en zh
start-guide-en start-guide-zh
logger-caveat-en logger-caveat-zh
app-webview-en app-webview-zh
logger-export-en logger-export-zh
Mac.mp4
iOS.mp4

@ACTCD ACTCD linked an issue Dec 28, 2024 that may be closed by this pull request
Better OOBE and User Guide #500
Closed
@ACTCD ACTCD requested a review from quoid December 28, 2024 08:18
@ACTCD ACTCD mentioned this pull request Dec 28, 2024
Open
quoid
quoid approved these changes Dec 31, 2024
View reviewed changes
Copy link
Owner

@quoid quoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I left some feedback regarding the English text, but otherwise, let's get to testing! :shipit:

src/app/_locales/en/quick-start-guide-ios.md Outdated Show resolved Hide resolved
src/app/_locales/en/quick-start-guide-ios.md Outdated Show resolved Hide resolved
src/app/_locales/en/quick-start-guide-ios.md Outdated Show resolved Hide resolved
src/app/_locales/en/quick-start-guide-ios.md Outdated Show resolved Hide resolved
src/app/_locales/en/quick-start-guide-mac.md Outdated Show resolved Hide resolved
src/app/_locales/en/quick-start-guide-mac.md Outdated Show resolved Hide resolved
@ACTCD @quoid
chore: adjust english expressions
7622730 
Apply suggestions from code review

Co-authored-by: Justin Wasack <[email protected]>
@ACTCD ACTCD merged commit 4329566 into main Dec 31, 2024
1 check passed
@ACTCD ACTCD deleted the feat/native-logger-and-better-oobe branch December 31, 2024 05:20
@ACTCD ACTCD mentioned this pull request Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quoid quoid quoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better OOBE and User Guide
2 participants
@ACTCD @quoid