-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: build and development improvements #478
Conversation
@Citizen2023 v5 is in progress and will take many months to complete. Feel free to clone and build on your own system. Please keep comments in the PR thread specific to the code changes in the PR. |
Acknowledged.
…On Mon, May 1, 2023 at 3:50 PM Justin Wasack ***@***.***> wrote:
@Citizen2023 <https://github.com/Citizen2023> v5 is in progress and will
take many months to complete. Feel free to clone and build on your own
system. Please keep comments in the PR thread specific to the code changes
in the PR.
—
Reply to this email directly, view it on GitHub
<#478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6PLA7BIHEIJC3G6AMNX6I3XEAOYTANCNFSM6AAAAAAXSFG2ZM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just part review of the first commit, which I will do in multiple times.
This comment was marked as off-topic.
This comment was marked as off-topic.
To be clear the feature you are requesting is to dynamically generate filter dimensions based off of the data a user has in their scripts and allow the user to filter against these dimensions in some unmentioned area of the extension (popup or page).
The second feature request is to separate style and js user scripts specifically with tabs in the extension menu (popup?) Either way, this is not the place to ask for feature enhancements, you can do that in the discussions or issues area. Thanks 😄 |
Reference each commit for what was done. This PR should be rebased into
v5
to ensure each commit is present in the history.