Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Reporter: Add showskipped option #1315

Closed
wants to merge 2 commits into from
Closed

Conversation

sechel
Copy link

@sechel sechel commented Sep 27, 2018

Hi, I felt that the default option to show skipped tests should be false. So I added an option to show the skipped tests to the HTML reporter.

@jsf-clabot
Copy link

jsf-clabot commented Sep 27, 2018

CLA assistant check
All committers have signed the CLA.

@Krinkle Krinkle added Component: HTML Reporter Category: API Type: Meta Seek input from maintainers and contributors. labels Dec 29, 2018
@Krinkle
Copy link
Member

Krinkle commented Dec 29, 2018

Hi @sechel, thanks for submitting this proposal.

Sorry for the delay in reviewing this, going through a bit of a backlog now. From a quick glance, it appears this proposal would change the API of the HTML reporter. As such, I'm tagging it as meta to also seek input from others (from anyone, but especially core team).

@trentmwillis
Copy link
Member

A relevant issue for this feature: #1208

In general, I am in favor of this feature, but I think we'll need to refactor the UI some to avoid it becoming too cluttered. I mentioned this in the issue above at #1208 (comment).

@Krinkle
Copy link
Member

Krinkle commented Jun 19, 2020

I'm declining this for now. I think hiding this by default has potential to hide issues or make it more difficult to figure out what's wrong when investigating an issue. The list of tests that have been run or considred to run is imho expected to be complete.

I do note that currently "hiding passed" is leaving skipped ones behind. I'll close this but leave the ticket open to ask about changing that.

@Krinkle Krinkle closed this Jun 19, 2020
@Krinkle Krinkle mentioned this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: API Component: HTML Reporter Type: Meta Seek input from maintainers and contributors.
Development

Successfully merging this pull request may close these issues.

4 participants