raidboss: Lunar Subterrane -- Add Forsaken Fount triggers #5926
Conversation
| const xSum = data.fountX.reduce((a, b) => a + b, 0); | ||
|
|
||
| // Don't rely on the rounded sum to be precise, but the sign will be reliable. | ||
| if (xSum > 5) |
There was a problem hiding this comment.
Can you give an example of what these >5, <5, >10, <10 patterns look like in terms of values? Summing makes sense as a way to differentiate between cases when you know the full set of examples, but it's a bit confusing to a reader. (Also, minorly and mostly curiously rather than something to fix, it makes me wonder if there's some simpler way to differentiate?)
There was a problem hiding this comment.
Sure, here's a raw list of configurations:
West Safe
(-12.80,-422.00), (0.00,-422.00), (12.80,-422.00)
(9.15,-431.10)
(3.65,-412.90)
North Safe
(0.00,-409.20), (0.00,-422.00), (0.00,-434.80)
(9.05,-412.80)
(-9.05,-418.35)
East Safe
(-12.80,-422.00), (0.00,-422.00), (12.80,-422.00)
(-9.25,-431.05)
(-3.65,-412.95)
Hourglass
(0.00,-409.20), (0.00,-422.00), (0.00,-434.80)
(-9.05,-418.35)
(9.15,-425.55)
And Y-normalized (for readers not as familiar, remember that positive Y values are south, not north!)
West Safe
(-12.80,0), (0,0), (12.8,0)
(9.15,-9.1)
(3.65,9.1)
North Safe
(0,12.8), (0,0), (0,-12.8)
(9.05,9.2)
(-9.05,3.65)
East Safe
(-12.8,0), (0,0), (12.8,0)
(-9.25,-9.05)
(-3.65,9.05)
Hourglass
(0,12.8), (0,0), (0,-12.8)
(-9.05,3.65)
(9.15,-3.55)
I'm not completely sure this list is exhaustive, but I'm confident the list of orb locations in the inline comment is.
There was a problem hiding this comment.
That makes sense! Can you add this as a comment somehow?
There was a problem hiding this comment.
Let's try this. I don't like how long it is, but the information is there. I also added some more in-line comments at the points where the output is actually returned.
There was a problem hiding this comment.
Thanks, I think that's helpful for future debugging, especially the "this probably does not exist" kind of comment.
The in-line comments should largely cover everything. It's maybe more complex than other possibilities for how we can handle the situation, but it does work.