add report download tests #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himmAllRight
changed the title
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 76.23% 76.23%
=======================================
Files 5 5
Lines 202 202
=======================================
Hits 154 154
Misses 48 48Continue to review full report at Codecov.
|
kdelee
reviewed
Dec 10, 2018
kdelee
suggested changes
Dec 10, 2018
There was a problem hiding this comment.
Looking good, lets make the failed assert messages a bit more verbose. Been dealing with alot of bare assert messages lately and it is making me realize how valuable it is to encapsulate this knowledge you currently have in the form of those failure messages.
kdelee
approved these changes
Dec 10, 2018
|
I ran it forcing a test or two to break to check the error messages, and then ran it again without the forced breaks. Should be okay. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new tests for
qpc report download.Also, removed some unused packages to fix Travis builds.