Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix iOS setsockopt invalid params #849

Merged
merged 1 commit into from
Sep 12, 2020
Merged

fix iOS setsockopt invalid params #849

merged 1 commit into from
Sep 12, 2020

Conversation

SSebo
Copy link
Contributor

@SSebo SSebo commented Sep 12, 2020 •
edited
Loading

fix #848

djc
djc approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc merged commit c0eaab7 into quinn-rs:master Sep 12, 2020
@SSebo
Copy link
Contributor Author

SSebo commented Sep 12, 2020

@djc Thank you for creating quinn!

@djc
Copy link
Member

djc commented Sep 12, 2020

@SSebo so are you using Quinn for TiKV/TiDB or something else? Just out of curiosity!

@SSebo
Copy link
Contributor Author

SSebo commented Nov 4, 2020 •
edited
Loading

@SSebo so are you using Quinn for TiKV/TiDB or something else? Just out of curiosity!

@djc Oh, I use it for an instant messaging system with thousands of iOS and Android devices.
Quinn is very powerful when users in weak signal cellular network or switch network from 4G to WIFI.

BTW, I found this commit is missing in main branch. Should I make a new PR?

@djc
Copy link
Member

djc commented Nov 5, 2020

Oh, sounds cool! Is the instant messaging system public, or something proprietary?

It seems like it's there just fine: https://github.com/quinn-rs/quinn/blob/main/quinn/src/platform/unix.rs#L42.

@SSebo
Copy link
Contributor Author

SSebo commented Nov 25, 2020 •
edited
Loading

Right now the whole system is not public. We will open source the connection management sub system which is powered by quinn when we think it is stable.

@thomaseizinger thomaseizinger mentioned this pull request Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to set up UDP socket: Invalid argument (os error 22) on iOS
2 participants
@SSebo @djc