Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent GSO logic on Unix platforms #2047

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Fix inconsistent GSO logic on Unix platforms #2047

merged 3 commits into from
Nov 17, 2024

Conversation

Ralith
Copy link
Collaborator

@Ralith Ralith commented Nov 16, 2024

Fixes #2042.

@Ralith Ralith force-pushed the fix-other-unix-gso branch 3 times, most recently from cdfcbf0 to 37d0580 Compare November 17, 2024 05:41
@Ralith Ralith force-pushed the fix-other-unix-gso branch from 37d0580 to ef64bd5 Compare November 17, 2024 05:43
@Ralith
Copy link
Collaborator Author

Ralith commented Nov 17, 2024

Looks like we discussed this before in #1758 and deemed it reasonable. CC @conectado, you might be interested to see this land.

@Ralith Ralith force-pushed the fix-other-unix-gso branch from ef64bd5 to fc21bb6 Compare November 17, 2024 05:52
@Ralith Ralith force-pushed the fix-other-unix-gso branch from fc21bb6 to 657bc3d Compare November 17, 2024 06:11
@djc djc added this pull request to the merge queue Nov 17, 2024
Merged via the queue into main with commit a694602 Nov 17, 2024
17 checks passed
@djc djc deleted the fix-other-unix-gso branch November 17, 2024 07:34
Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 11, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Dec 12, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Dec 13, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505

UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Dec 13, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505

UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Dec 13, 2024
…chain-reviewers

`quinn-udp` `v0.5.8` contains an intermediary fix for Bug 1916558, see
quinn-rs/quinn#2071.

In addition `quinn-udp` `v0.5.8` Includes the following bugfixes:

- quinn-rs/quinn#2072
- quinn-rs/quinn#2073
- quinn-rs/quinn#2074
- quinn-rs/quinn#2050
- quinn-rs/quinn#2047

Differential Revision: https://phabricator.services.mozilla.com/D231505

UltraBlame original commit: a8cd98601fdff821fe9cc516ddb61f54c104fb58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android is broken on master (GSO is enabled)
3 participants