feat: introduce UdpSocketState::try_send APIs
#2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
force-pushed
the
feat/add-try-send
branch
2 times, most recently
from
a3d8720
to
e617ab9
Compare
djc
approved these changes
Oct 21, 2024
|
@djc Can the feedback be in follow-up commits or should I amend? |
Please amend so that we end up with a clean commit series to review. |
This makes it more apparent that this logging is happening because users are more likely to read at least the first "layer" of the APIs they are using. In addition, we are going to offer a `try_send` API which requires us to decouple the `send` free-function from this logging behaviour.
thomaseizinger
force-pushed
the
feat/add-try-send
branch
from
e515a27
to
6fa3674
Compare
thomaseizinger
force-pushed
the
feat/add-try-send
branch
from
6fa3674
to
ce7bcbe
Compare
This allows us to have it follow the exact same implementation as the unix and windows one.
thomaseizinger
force-pushed
the
feat/add-try-send
branch
from
ce7bcbe
to
13139d7
Compare
|
Just fixed up CI, sorry for the hickup! |
Ralith
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1971.