crypto: expose negotiated_cipher_suite in the hadshake data #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Oct 4, 2024
Once |
Ralith
approved these changes
Oct 25, 2024
BiagioFesta
force-pushed
the
wip/bfesta/hsd-cipher-info
branch
from
bc0389e
to
2e56fc2
Compare
|
Note this is technically a breaking change, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
I am not totally convinced by that
.expect("cipher is negotiated").It makes sense to me: as AFAIK reaching that point always implies the cipher is negotiated, but I might have missed a edge scenario