Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump quinn to enforce patched quinn-proto #1979

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

finnbear
Copy link
Contributor

@finnbear finnbear commented Sep 2, 2024

Now crates like wtransport, that only depend on quinn and use quinn-proto via quinn::proto, can point to a patched version.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo update (or the default behavior when adding a new dependency) will be sufficient to get the latest quinn-proto regardless, so I'm not sure this is strictly needed. Still, no harm, and I wouldn't mind getting #1977 published.

@finnbear
Copy link
Contributor Author

finnbear commented Sep 2, 2024

cargo update

FWIW, once your nightly library code base has hundreds of dependencies, cargo update (or removing Cargo.lock) becomes hazardous (e.g. introduces incompatibilities due to SEMVER mistakes and changing nightly features) and it's safer to depend on exact versions of dependencies and manually update the important ones occasionally (but you can only do that with direct dependencies, not transitives ones).

@Ralith
Copy link
Collaborator

Ralith commented Sep 2, 2024

cargo update can also target individual transitive dependencies if you don't want to do everything at once.

@finnbear
Copy link
Contributor Author

finnbear commented Sep 2, 2024

cargo update can also target individual transitive dependencies if you don't want to do everything at once.

You're right, but if you use your library in 5 different places (say you use your game engine in 5 different games), then you would have to remember to run cargo update --package quinn-proto in those 5 places (where the Cargo.lock files live).

Maybe this is really niche 😂

@djc djc added this pull request to the merge queue Sep 3, 2024
Merged via the queue into quinn-rs:main with commit 59bccd2 Sep 3, 2024
13 checks passed
@djc
Copy link
Member

djc commented Sep 3, 2024

  • Published quinn-proto v0.11.8 at registry crates-io
  • Published quinn v0.11.5 at registry crates-io
  • [new tag] quinn-0.11.5 -> quinn-0.11.5
  • [new tag] quinn-proto-0.11.8 -> quinn-proto-0.11.8
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants