-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(rust.yml): add job testing feature permutations #1934
Conversation
3e50571
to
1b121e6
Compare
96523a6
to
34388f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay, and the runtime is probably worth it.
Thanks for working on this!
@djc I did the rename. Mind taking another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks like this needs a rebase. |
Head branch was pushed to by a user without write access
355c2bc
to
9770a2a
Compare
This pull request adds a GitHub job, testing all feature permutations (including optional dependencies), across all default workspace members. It uses
cargo hack
.This workflow would for example have caught the following recent bugs before landing in
main
:Right now this job takes 5m 1s on Ubuntu, 4m 42s on MacOS and 8m 29s Windows. In case you consider that too long, we could drop
--optional-deps
or exclude some features (--exclude-features
).