bench(udp): measure non-GSO & GSO on localhost #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a basic benchmark, measuring the time to transfer 10 MiB with
and without GSO on localhost.
```
gso_false/throughput time: [23.455 ms 25.230 ms 27.004 ms]
thrpt: [370.31 MiB/s 396.35 MiB/s 426.35 MiB/s]
gso_true/throughput time: [1.0168 ms 1.1239 ms 1.2496 ms]
thrpt: [7.8153 GiB/s 8.6889 GiB/s 9.6044 GiB/s]
```
```
$ cat /proc/cpuinfo
model name : 12th Gen Intel(R) Core(TM) i9-12900HK
```
Ralith
approved these changes
Jul 5, 2024
Otherwise e.g. FreeBSD complains with:
```
error[E0601]: `main` function not found in crate `throughput`
--> quinn-udp/benches/throughput.rs:77:26
|
77 | criterion_main!(benches);
| ^ consider adding a `main` function to `quinn-udp/benches/throughput.rs`
```
djc
approved these changes
Jul 8, 2024
flub
pushed a commit
to n0-computer/quinn
that referenced
this pull request
Aug 6, 2024
This commit adds a basic benchmark, measuring the time to transfer 10
MiB with and without GSO on localhost.
```
gso_false/throughput time: [23.455 ms 25.230 ms 27.004 ms]
thrpt: [370.31 MiB/s 396.35 MiB/s 426.35 MiB/s]
gso_true/throughput time: [1.0168 ms 1.1239 ms 1.2496 ms]
thrpt: [7.8153 GiB/s 8.6889 GiB/s 9.6044 GiB/s]
```
```
$ cat /proc/cpuinfo
model name : 12th Gen Intel(R) Core(TM) i9-12900HK
```
---
Given various optimizations for `localhost` traffic on Linux, we were
wondering whether GSO actually has an impact on `localhost`. According
to this benchmark: Yes it does.
For what a `localhost` network benchmark is worth, here it is. Feel free
to close in case it isn't useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a basic benchmark, measuring the time to transfer 10 MiB with and without GSO on localhost.
Given various optimizations for
localhosttraffic on Linux, we were wondering whether GSO actually has an impact onlocalhost. According to this benchmark: Yes it does.For what a
localhostnetwork benchmark is worth, here it is. Feel free to close in case it isn't useful.