Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(quinn): Clarify effects of setting AckFrequencyConfig #1894

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

gretchenfrage
Copy link
Contributor

Per discussion in Discord [link], the actual extent to which setting ack_frequency_config to None disables the acknowledgement frequency extension is less than the documentation seems to imply. An endpoint with the ack frequency config set to None will still:

  • advertise support for the extension by populating the min_ack_delay field of its transport parameters with Some
  • process ACK_FREQUENCY and IMMEDIATE_ACK frames if it receives them
  • send IMMEDIATE_ACK frames if the peer advertises support for the extension

The only thing it will not do is send the peer an ACK_FREQUENCY frame.

This PR updates the docs to reflect the behavior more closely.

@Ralith Ralith merged commit 11050d6 into quinn-rs:main Jun 9, 2024
8 checks passed
@Ralith
Copy link
Collaborator

Ralith commented Jun 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants