Enable ios for the same os_type checks as macos
#1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Mar 23, 2024
|
Thanks! Looks like this causes some issues in CI? |
|
Hmm, is the CI expected to fail for this? I would not have expected this change to affect |
|
248ac33 fixes the issue. Sorry about that! Glad CI caught it. Please give it a once-over. Thanks for accepting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that IPv4-only is broken on iOS.
Enabling the same code paths for ios that exist for macos fixes all issues. In our testing, we've found the network stacks to be nearly identical between iOS and macOS.
This fork has been tested on 3 physical iOS devices with IPv4-only, IPv6-only, and dual stack configurations on iOS 17.
Thanks for the great library. Happy to do any further testing!