udp: disable GSO on EINVAL #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Aug 20, 2023
Linux 5.15 was observed to emit an EINVAL when attempting to transmit UDP with GSO over IPv6 on a virtio net interface. 6.1 was also observed to emit EINVAL, though only after EIO. In both cases, EINVAL was suppressed by disabling GSO.
mzz2017
added a commit
to daeuniverse/quic-go
that referenced
this pull request
Sep 2, 2023
mzz2017
added a commit
to daeuniverse/quic-go
that referenced
this pull request
Sep 2, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux 5.15 was observed to emit an EINVAL when attempting to transmit UDP with GSO over IPv6 on a virtio net interface, which apparently only supports UDP GSO on IPv6 as of Linux 6.2. 6.1 was also observed to emit EINVAL, though only after EIO. In both cases, EINVAL was suppressed by disabling GSO.
Companion change to #1636. I don't fully understand why Linux is returning EINVAL in these cases, so I'm not 100% certain this is the correct fix, but at the very least it won't hurt.