-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport supress stateless packet to 0.10.x #1598
Backport supress stateless packet to 0.10.x #1598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see why you were thinking about separate methods now. I'm happy either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far, but did you also want to disable version negotiation and stateless reset packets under the heavily loaded condition?
Great point! I reviewed the implementation in main -- we were suppressing version negotiation and stateless reset packets as well. I will add these into the consideration as well to keep it consistent and more robust. |
…eset as well under load
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Backport e652b6d from main to 0.10.x branch.
The implementation is different from the main branch due to the refactoring happened to main branch.